[
https://issues.apache.org/jira/browse/BEAM-4137?focusedWorklogId=118985&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-118985
]
ASF GitHub Bot logged work on BEAM-4137:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Jul/18 08:05
Start Date: 04/Jul/18 08:05
Worklog Time Spent: 10m
Work Description: lgajowy commented on a change in pull request #5876:
[BEAM-4137] Divide elasticsearch pipeline options
URL: https://github.com/apache/beam/pull/5876#discussion_r200040448
##########
File path:
sdks/java/io/common/src/test/java/org/apache/beam/sdk/io/common/IOTestPipelineOptions.java
##########
@@ -21,31 +21,8 @@
import org.apache.beam.sdk.options.Description;
import org.apache.beam.sdk.testing.TestPipelineOptions;
-/**
- * This shared set of options is used so that the full suite of IO tests can
be run in one pass - if
- * a test tries to read TestPipelineOptions, it must be able to understand all
the options that were
- * passed on the command line.
- */
+/** Pipeline options common for IO integration tests. */
public interface IOTestPipelineOptions extends TestPipelineOptions {
- /* Elasticsearch */
- @Description("Server name for Elasticsearch server (host name/ip address)")
- @Default.String("elasticsearch-server-name")
- String getElasticsearchServer();
-
- void setElasticsearchServer(String value);
-
- @Description("Http port for elasticsearch server")
- @Default.Integer(9200)
- Integer getElasticsearchHttpPort();
-
- void setElasticsearchHttpPort(Integer value);
-
- /* Solr */
Review comment:
As for solr - I didn't find any usages of those options - there are no Solr
tests nor any code that use it. It's a dead code so I deleted it. I isolated
the removal in a separate commit. Isn't this enough?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 118985)
Time Spent: 9h (was: 8h 50m)
> Split IOTestPipelineOptions to multiple, test-specific files
> ------------------------------------------------------------
>
> Key: BEAM-4137
> URL: https://issues.apache.org/jira/browse/BEAM-4137
> Project: Beam
> Issue Type: Improvement
> Components: testing
> Reporter: Łukasz Gajowy
> Assignee: Łukasz Gajowy
> Priority: Minor
> Time Spent: 9h
> Remaining Estimate: 0h
>
> Currently we have one big IOTestPipelineOptions interface that is used in
> many IOITs. It contains test specific options that should rather be located
> next to testing classes, not in a generic file. Let's split this.
> Additionally, besides separation of concerns, this will allow adding
> test-specific @Default and @Required annotations and validate the options
> better.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
