[
https://issues.apache.org/jira/browse/BEAM-4137?focusedWorklogId=118987&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-118987
]
ASF GitHub Bot logged work on BEAM-4137:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Jul/18 08:12
Start Date: 04/Jul/18 08:12
Worklog Time Spent: 10m
Work Description: lgajowy edited a comment on issue #5876: [BEAM-4137]
Divide elasticsearch pipeline options
URL: https://github.com/apache/beam/pull/5876#issuecomment-402400371
@echauchot phrase triggering is impossible now on the current codebase. It
would be possible only when a Jenkins job exists that runs the elasticsearch
tests. There is no such job yet - this is another task [that is yet to be
done](https://issues.apache.org/jira/browse/BEAM-4398). I just refactored here
simply to finish BEAM-4137. However, FWIW, I tested this locally and it reads
the options well. Please let me know if such test is enough.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 118987)
Time Spent: 9h 20m (was: 9h 10m)
> Split IOTestPipelineOptions to multiple, test-specific files
> ------------------------------------------------------------
>
> Key: BEAM-4137
> URL: https://issues.apache.org/jira/browse/BEAM-4137
> Project: Beam
> Issue Type: Improvement
> Components: testing
> Reporter: Łukasz Gajowy
> Assignee: Łukasz Gajowy
> Priority: Minor
> Time Spent: 9h 20m
> Remaining Estimate: 0h
>
> Currently we have one big IOTestPipelineOptions interface that is used in
> many IOITs. It contains test specific options that should rather be located
> next to testing classes, not in a generic file. Let's split this.
> Additionally, besides separation of concerns, this will allow adding
> test-specific @Default and @Required annotations and validate the options
> better.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
