[
https://issues.apache.org/jira/browse/BEAM-4742?focusedWorklogId=120882&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-120882
]
ASF GitHub Bot logged work on BEAM-4742:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jul/18 16:48
Start Date: 09/Jul/18 16:48
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #5902:
[BEAM-4742] allow custom docker image in portable runner
URL: https://github.com/apache/beam/pull/5902#discussion_r201071859
##########
File path: sdks/python/apache_beam/runners/portability/portable_runner.py
##########
@@ -59,7 +59,15 @@ def __init__(self, is_embedded_fnapi_runner=False):
@staticmethod
def default_docker_image():
- if 'USER' in os.environ:
+ if 'DOCKER_IMAGE' in os.environ:
Review comment:
This is already controlled by the flag `--harness_docker_image`:
https://github.com/apache/beam/blob/385faa713951813371dffaf654b5dc8d96e27aa1/sdks/python/apache_beam/options/pipeline_options.py#L648
Do you still want to make the default container selection be based off of
`DOCKER_IMAGE`?
If yes, should it specify the full path and not assume the user wants the
`:latest` suffix?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 120882)
Time Spent: 20m (was: 10m)
> Allow custom docker-image in portable wordcount example
> -------------------------------------------------------
>
> Key: BEAM-4742
> URL: https://issues.apache.org/jira/browse/BEAM-4742
> Project: Beam
> Issue Type: Improvement
> Components: examples-python
> Affects Versions: 2.5.0
> Reporter: Ryan Williams
> Assignee: Ryan Williams
> Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> I hit a couple snags [running the portable wordcount
> example|https://github.com/apache/beam/blob/997ee3afe74483ae44e2dcb32ca0e24876129cd9/sdks/python/build.gradle#L200-L214]:
> * [the default docker image is hard-coded to a bintray
> URL|https://github.com/apache/beam/blob/997ee3afe74483ae44e2dcb32ca0e24876129cd9/sdks/python/apache_beam/runners/portability/portable_runner.py#L60-L68],
> but I published my image to Docker Hub
> * the default output path is in a temporary directory that doesn't exist at
> the time of the {{open}} call, so I got {{IOError: [Errno 2] No such file or
> directory}}
> I'll send a PR with fixes to each of these shortly.
> I've also not found where to observe output from successfully running the
> example.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
