[
https://issues.apache.org/jira/browse/BEAM-4742?focusedWorklogId=120919&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-120919
]
ASF GitHub Bot logged work on BEAM-4742:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jul/18 17:50
Start Date: 09/Jul/18 17:50
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #5903:
[BEAM-4742] mkdirs if they don't exist in localfilesystem
URL: https://github.com/apache/beam/pull/5903#discussion_r201089697
##########
File path: sdks/python/apache_beam/io/localfilesystem.py
##########
@@ -127,6 +127,9 @@ def _path_open(self, path, mode,
mime_type='application/octet-stream',
"""Helper functions to open a file in the provided mode.
"""
compression_type = FileSystem._get_compression_type(path, compression_type)
+ parent = os.path.dirname(path)
Review comment:
We should only create the path in the `create` call and not the `open` call
as we'll get a weird error if the user mistypes the path for something being
read and we will try to create the directory which may fail (e.g. permissions)
which will raise a confusing error message.
Do you want to add a test to localfilesystem_test.py so that this isn't
regressed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 120919)
Time Spent: 1h 50m (was: 1h 40m)
> Allow custom docker-image in portable wordcount example
> -------------------------------------------------------
>
> Key: BEAM-4742
> URL: https://issues.apache.org/jira/browse/BEAM-4742
> Project: Beam
> Issue Type: Improvement
> Components: examples-python
> Affects Versions: 2.5.0
> Reporter: Ryan Williams
> Assignee: Ryan Williams
> Priority: Minor
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> I hit a couple snags [running the portable wordcount
> example|https://github.com/apache/beam/blob/997ee3afe74483ae44e2dcb32ca0e24876129cd9/sdks/python/build.gradle#L200-L214]:
> * -[the default docker image is hard-coded to a bintray
> URL|https://github.com/apache/beam/blob/997ee3afe74483ae44e2dcb32ca0e24876129cd9/sdks/python/apache_beam/runners/portability/portable_runner.py#L60-L68],
> but I published my image to Docker Hub- I missed that [there's already a
> pipeline option for
> this|https://github.com/apache/beam/pull/5902#discussion_r201071859]! Thanks
> [~lcwik]
> * the default output path is in a temporary directory that doesn't exist at
> the time of the {{open}} call, so I got {{IOError: [Errno 2] No such file or
> directory}}
> I'll send a PR with fixes to each of these shortly.
> I've also not found where to observe output from successfully running the
> example.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
