ASF GitHub Bot logged work on BEAM-4726:

                Author: ASF GitHub Bot
            Created on: 11/Jul/18 18:06
            Start Date: 11/Jul/18 18:06
    Worklog Time Spent: 10m 
      Work Description: lostluck commented on a change in pull request #5882: 
[BEAM-4726] Cache fixed per function Invoke values
URL: https://github.com/apache/beam/pull/5882#discussion_r201789427

 File path: sdks/go/pkg/beam/core/runtime/exec/pardo.go
 @@ -217,6 +221,27 @@ func (n *ParDo) invokeDataFn(ctx context.Context, ws 
[]typex.Window, ts typex.Ev
        return val, err
+// invokeProcessFn handles the per element invocations
+func (n *ParDo) invokeProcessFn(ctx context.Context, ws []typex.Window, ts 
typex.EventTime, opt *MainInput) (*FullValue, error) {
+       for _, e := range n.emitters {
 Review comment:
   I ended up having Invoke create a new invoker and calling the method instead 
of having two implementations of Invoke.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

Issue Time Tracking

    Worklog Id:     (was: 121995)
    Time Spent: 5h 10m  (was: 5h)

> Reduce ParDo per element Invoke overhead
> ----------------------------------------
>                 Key: BEAM-4726
>                 URL: https://issues.apache.org/jira/browse/BEAM-4726
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-go
>            Reporter: Robert Burke
>            Assignee: Robert Burke
>            Priority: Major
>          Time Spent: 5h 10m
>  Remaining Estimate: 0h
> Each call to invoke allocates a new args []interface{}, but the common case 
> is to run the same ProcessElement function over and again. It should be 
> possible to have a container struct to retain the args slice, and avoid 
> recomputing the indices for where to assign parameters before calling the 
> ProcessElementFn.

This message was sent by Atlassian JIRA

Reply via email to