ASF GitHub Bot logged work on BEAM-4726:

                Author: ASF GitHub Bot
            Created on: 11/Jul/18 20:35
            Start Date: 11/Jul/18 20:35
    Worklog Time Spent: 10m 
      Work Description: herohde commented on a change in pull request #5882: 
[BEAM-4726] Cache fixed per function Invoke values
URL: https://github.com/apache/beam/pull/5882#discussion_r201828076

 File path: sdks/go/pkg/beam/core/runtime/exec/fn_test.go
 @@ -150,7 +150,6 @@ func BenchmarkDirectCall(b *testing.B) {
        for i := 0; i < b.N; i++ {
                n = inc(n)
-       b.Log(n)
 Review comment:
   We should keep the log statements. Otherwise, there is no observable output 
as 'n' is never used and a clever global optimizer could remove what we're 
trying to measure. It also allows manual inspection that something was computed 
when run. Is there a reason these were removed?

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

Issue Time Tracking

    Worklog Id:     (was: 122036)
    Time Spent: 5.5h  (was: 5h 20m)

> Reduce ParDo per element Invoke overhead
> ----------------------------------------
>                 Key: BEAM-4726
>                 URL: https://issues.apache.org/jira/browse/BEAM-4726
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-go
>            Reporter: Robert Burke
>            Assignee: Robert Burke
>            Priority: Major
>          Time Spent: 5.5h
>  Remaining Estimate: 0h
> Each call to invoke allocates a new args []interface{}, but the common case 
> is to run the same ProcessElement function over and again. It should be 
> possible to have a container struct to retain the args slice, and avoid 
> recomputing the indices for where to assign parameters before calling the 
> ProcessElementFn.

This message was sent by Atlassian JIRA

Reply via email to