[
https://issues.apache.org/jira/browse/BEAM-4723?focusedWorklogId=122061&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-122061
]
ASF GitHub Bot logged work on BEAM-4723:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Jul/18 22:55
Start Date: 11/Jul/18 22:55
Worklog Time Spent: 10m
Work Description: amaliujia commented on a change in pull request #5926:
[BEAM-4723] [SQL] Support datetime type minus time interval
URL: https://github.com/apache/beam/pull/5926#discussion_r201864495
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/interpreter/operator/date/BeamSqlTimestampMinusIntervalExpression.java
##########
@@ -41,7 +39,7 @@
public BeamSqlTimestampMinusIntervalExpression(
List<BeamSqlExpression> operands, SqlTypeName outputType) {
- super(operands, outputType);
+ super(operands, SqlTypeName.TIMESTAMP);
Review comment:
Seems like outputType will be unused.
Why do you need to have a fixed parameter `SqlTypeName.TIMESTAMP`? If this
is correct then unused function parameter is supposed to be removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 122061)
Time Spent: 1h 10m (was: 1h)
> Enhance Datetime*Expression Datetime Type
> -----------------------------------------
>
> Key: BEAM-4723
> URL: https://issues.apache.org/jira/browse/BEAM-4723
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql
> Reporter: Kai Jiang
> Assignee: Kai Jiang
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Datetime*Expression only supports timestamp type for first operand now. We
> should let it accept all Datetime_Types
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
