[
https://issues.apache.org/jira/browse/BEAM-4723?focusedWorklogId=124216&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-124216
]
ASF GitHub Bot logged work on BEAM-4723:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Jul/18 21:02
Start Date: 17/Jul/18 21:02
Worklog Time Spent: 10m
Work Description: apilloud commented on a change in pull request #5926:
[BEAM-4723] [SQL] Support datetime type minus time interval
URL: https://github.com/apache/beam/pull/5926#discussion_r203176136
##########
File path:
sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/impl/interpreter/operator/date/BeamSqlTimestampMinusIntervalExpressionTest.java
##########
@@ -67,7 +66,7 @@ public void testBasicProperties() {
BeamSqlTimestampMinusIntervalExpression minusExpression =
minusExpression(SqlTypeName.INTERVAL_DAY_MINUTE, TIMESTAMP,
INTERVAL_3_MONTHS);
Review comment:
This test case is wrong. The resulting `minusExpression` will fail on
`accept()`. You should replace `INTERVAL_DAY_MINUTE` with `TIMESTAMP` for it to
be correct.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 124216)
Time Spent: 1h 40m (was: 1.5h)
> Enhance Datetime*Expression Datetime Type
> -----------------------------------------
>
> Key: BEAM-4723
> URL: https://issues.apache.org/jira/browse/BEAM-4723
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql
> Reporter: Kai Jiang
> Assignee: Kai Jiang
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Datetime*Expression only supports timestamp type for first operand now. We
> should let it accept all Datetime_Types
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
