[
https://issues.apache.org/jira/browse/BEAM-4176?focusedWorklogId=124691&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-124691
]
ASF GitHub Bot logged work on BEAM-4176:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Jul/18 23:15
Start Date: 18/Jul/18 23:15
Worklog Time Spent: 10m
Work Description: axelmagn commented on a change in pull request #5935:
[BEAM-4176] Initial implementation for running portable runner tests
URL: https://github.com/apache/beam/pull/5935#discussion_r203560094
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkJobServerDriver.java
##########
@@ -45,9 +46,12 @@
private final ListeningExecutorService executor;
private final ServerConfiguration configuration;
private final ServerFactory serverFactory;
+ private GrpcFnServer<InMemoryJobService> jobServer;
+ private GrpcFnServer<BeamFileSystemArtifactStagingService>
artifactStagingServer;
- private static class ServerConfiguration {
- @Option(name = "--job-host", required = true, usage = "The job server host
string")
+ /** Configuration for the jobServer. */
+ public static class ServerConfiguration {
+ @Option(name = "--job-host", usage = "The job server host string")
Review comment:
Gotcha. that makes sense.
I have no idea about other ways to manage unused ports (short of writing our
own manager), so I think you're right that this is the way to do it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 124691)
Time Spent: 50m (was: 40m)
> Java: Portable batch runner passes all ValidatesRunner tests that
> non-portable runner passes
> --------------------------------------------------------------------------------------------
>
> Key: BEAM-4176
> URL: https://issues.apache.org/jira/browse/BEAM-4176
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Reporter: Ben Sidhom
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> We need this as a sanity check that runner execution is correct.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
