[
https://issues.apache.org/jira/browse/BEAM-4176?focusedWorklogId=125650&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-125650
]
ASF GitHub Bot logged work on BEAM-4176:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Jul/18 21:11
Start Date: 20/Jul/18 21:11
Worklog Time Spent: 10m
Work Description: bsidhom commented on a change in pull request #5935:
[BEAM-4176] Initial implementation for running portable runner tests
URL: https://github.com/apache/beam/pull/5935#discussion_r204170154
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkJobServerDriver.java
##########
@@ -45,9 +46,12 @@
private final ListeningExecutorService executor;
private final ServerConfiguration configuration;
private final ServerFactory serverFactory;
+ private GrpcFnServer<InMemoryJobService> jobServer;
+ private GrpcFnServer<BeamFileSystemArtifactStagingService>
artifactStagingServer;
- private static class ServerConfiguration {
- @Option(name = "--job-host", required = true, usage = "The job server host
string")
+ /** Configuration for the jobServer. */
+ public static class ServerConfiguration {
+ @Option(name = "--job-host", usage = "The job server host string")
Review comment:
Is this a local port? If so, it's quite easy to do in Java by allocating a
new TCP server socket at port 0. You can then query it for the chosen port.
This works as long as you are able to pass that socket directly to the service
implementation. (Note that you can do this with gRPC and we have a
Beam-specific tool that does this for you).
If you're trying to find an unused port for a non-Java server or for a
server that will run separately (i.e., for which you do not directly control
the socket), you can use the same server allocation trick and note the chosen
port number. You can then kill the server socket and pass that port into your
new server's configuration. Note that doing this approach introduces a race
condition but will work in most cases (especially with retries).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 125650)
Time Spent: 1h 10m (was: 1h)
> Java: Portable batch runner passes all ValidatesRunner tests that
> non-portable runner passes
> --------------------------------------------------------------------------------------------
>
> Key: BEAM-4176
> URL: https://issues.apache.org/jira/browse/BEAM-4176
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Reporter: Ben Sidhom
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> We need this as a sanity check that runner execution is correct.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
