[
https://issues.apache.org/jira/browse/BEAM-4006?focusedWorklogId=125556&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-125556
]
ASF GitHub Bot logged work on BEAM-4006:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Jul/18 16:28
Start Date: 20/Jul/18 16:28
Worklog Time Spent: 10m
Work Description: Fematich commented on a change in pull request #5729:
[BEAM-4006] Futurize transforms subpackage
URL: https://github.com/apache/beam/pull/5729#discussion_r204099457
##########
File path: sdks/python/apache_beam/transforms/window.py
##########
@@ -234,6 +252,7 @@ def union(self, other):
min(self.start, other.start), max(self.end, other.end))
+@total_ordering
Review comment:
I have pushed a new commit that should speed up the compare functions for
`BoundedWindow` and `TimestampedValue` objects:
- removed the total_ordering decorator
- removed the custom cmp-method in `BoundedWindow`
- removed the if-statement in `TimestampedValue` using the short-circuit
behavior of `or`
All of these changes had a positive impact on a small test I used.
A microbenchmark in the apache beam code, would really be useful indeed :-)!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 125556)
Time Spent: 8h 40m (was: 8.5h)
> Futurize and fix python 2 compatibility for transforms subpackage
> -----------------------------------------------------------------
>
> Key: BEAM-4006
> URL: https://issues.apache.org/jira/browse/BEAM-4006
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Matthias Feys
> Priority: Major
> Time Spent: 8h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
