[
https://issues.apache.org/jira/browse/BEAM-4006?focusedWorklogId=126089&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-126089
]
ASF GitHub Bot logged work on BEAM-4006:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Jul/18 15:39
Start Date: 23/Jul/18 15:39
Worklog Time Spent: 10m
Work Description: tvalentyn commented on issue #5729: [BEAM-4006]
Futurize transforms subpackage
URL: https://github.com/apache/beam/pull/5729#issuecomment-407102486
I did not benchmark changes in c270644 yet, but doing bisection on previous
version of the PRs shows that the largest contributor to regression is the line
`from __future__ import division` in `util.py`. I still don't understand the
reason why it causes the regression. One place where we may have missed to
modify division is
https://github.com/Fematich/beam/blob/c2706447a6a602614c2f9bf36db1a666fa938819/sdks/python/apache_beam/transforms/util.py#L277
but changing division there to integer division does not seem to help. Looking
further.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 126089)
Time Spent: 8h 50m (was: 8h 40m)
> Futurize and fix python 2 compatibility for transforms subpackage
> -----------------------------------------------------------------
>
> Key: BEAM-4006
> URL: https://issues.apache.org/jira/browse/BEAM-4006
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Matthias Feys
> Priority: Major
> Time Spent: 8h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
