[
https://issues.apache.org/jira/browse/BEAM-4658?focusedWorklogId=127658&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-127658
]
ASF GitHub Bot logged work on BEAM-4658:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Jul/18 06:09
Start Date: 26/Jul/18 06:09
Worklog Time Spent: 10m
Work Description: youngoli commented on a change in pull request #6050:
[BEAM-4658] Update pipeline representation in runner support libraries to
handle timers.
URL: https://github.com/apache/beam/pull/6050#discussion_r205256708
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/ParDoTranslation.java
##########
@@ -337,11 +337,22 @@ public static TupleTagList
getAdditionalOutputTags(AppliedPTransform<?, ?, ?> ap
ptransform.getSpec().getUrn());
ParDoPayload payload =
ParDoPayload.parseFrom(ptransform.getSpec().getPayload());
return components.getPcollectionsOrThrow(
- ptransform.getInputsOrThrow(getMainInputId(ptransform, payload)));
+ ptransform.getInputsOrThrow(getMainInputName(ptransform, payload)));
Review comment:
Since you added a version of getMainInputName that retrieves the payload,
what about using that here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 127658)
Time Spent: 1h (was: 50m)
> Update pipeline representation in runner support libraries to handle timers
> ---------------------------------------------------------------------------
>
> Key: BEAM-4658
> URL: https://issues.apache.org/jira/browse/BEAM-4658
> Project: Beam
> Issue Type: Sub-task
> Components: runner-core
> Reporter: Luke Cwik
> Assignee: Luke Cwik
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Expose relevant timer information on *ExecutableStage* to runners
> Update fusion logic to handle timers.
> Provide execution time interface to fire timers into *RemoteBundle*s and also
> to receive new timers that are being set.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
