[ 
https://issues.apache.org/jira/browse/BEAM-4658?focusedWorklogId=127819&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-127819
 ]

ASF GitHub Bot logged work on BEAM-4658:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 26/Jul/18 15:58
            Start Date: 26/Jul/18 15:58
    Worklog Time Spent: 10m 
      Work Description: lukecwik commented on a change in pull request #6050: 
[BEAM-4658] Update pipeline representation in runner support libraries to 
handle timers.
URL: https://github.com/apache/beam/pull/6050#discussion_r205512043
 
 

 ##########
 File path: 
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/graph/ExecutableStage.java
 ##########
 @@ -104,7 +118,7 @@
    *   <li>The {@link PTransform#getSubtransformsList()} is empty. This 
ensures that executable
    *       stages are treated as primitive transforms.
    *   <li>The only {@link PCollection} in the {@link 
PTransform#getInputsMap()} is the result of
-   *       {@link #getInputPCollection()}.
+   *       {@link #getInputPCollection()} and {@link #getSideInputs()}.
 
 Review comment:
   It is multiple, fixed comment.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 127819)
    Time Spent: 1h 40m  (was: 1.5h)

> Update pipeline representation in runner support libraries to handle timers
> ---------------------------------------------------------------------------
>
>                 Key: BEAM-4658
>                 URL: https://issues.apache.org/jira/browse/BEAM-4658
>             Project: Beam
>          Issue Type: Sub-task
>          Components: runner-core
>            Reporter: Luke Cwik
>            Assignee: Luke Cwik
>            Priority: Major
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> Expose relevant timer information on *ExecutableStage* to runners
> Update fusion logic to handle timers.
> Provide execution time interface to fire timers into *RemoteBundle*s and also 
> to receive new timers that are being set.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to