[
https://issues.apache.org/jira/browse/BEAM-4006?focusedWorklogId=128066&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-128066
]
ASF GitHub Bot logged work on BEAM-4006:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Jul/18 06:10
Start Date: 27/Jul/18 06:10
Worklog Time Spent: 10m
Work Description: tvalentyn commented on a change in pull request #5729:
[BEAM-4006] Futurize transforms subpackage
URL: https://github.com/apache/beam/pull/5729#discussion_r205651979
##########
File path: sdks/python/apache_beam/transforms/window.py
##########
@@ -348,6 +388,9 @@ def __eq__(self, other):
if type(self) == type(other) == FixedWindows:
return self.size == other.size and self.offset == other.offset
+ def __hash__(self):
+ return hash((type(self), self.size, self.offset))
+
def __ne__(self, other):
Review comment:
Looks like classes `IntervalWindow`, `GlobalWindow`, `SlidingWindows`, and
`Sessions` define `__eq__`, but don't define `__ne__`.
Let's add:
```
def __ne__(self, other):
return not self == other
```
since this would be the default implementation of `__ne__` in Python 3.
Curious, why the conversion tool does not add something similar.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 128066)
Time Spent: 10h 50m (was: 10h 40m)
> Futurize and fix python 2 compatibility for transforms subpackage
> -----------------------------------------------------------------
>
> Key: BEAM-4006
> URL: https://issues.apache.org/jira/browse/BEAM-4006
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Matthias Feys
> Priority: Major
> Time Spent: 10h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
