[
https://issues.apache.org/jira/browse/BEAM-4006?focusedWorklogId=128254&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-128254
]
ASF GitHub Bot logged work on BEAM-4006:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Jul/18 18:46
Start Date: 27/Jul/18 18:46
Worklog Time Spent: 10m
Work Description: Fematich commented on a change in pull request #5729:
[BEAM-4006] Futurize transforms subpackage
URL: https://github.com/apache/beam/pull/5729#discussion_r205866972
##########
File path: sdks/python/apache_beam/transforms/window.py
##########
@@ -191,15 +192,31 @@ def __init__(self, end):
def max_timestamp(self):
return self.end.predecessor()
- def __cmp__(self, other):
- # Order first by endpoint, then arbitrarily.
- return cmp(self.end, other.end) or cmp(hash(self), hash(other))
-
def __eq__(self, other):
raise NotImplementedError
+ def __ne__(self, other):
+ return (cmp(self.end, other.end)
+ or cmp(hash(self), hash(other))) != 0
+
+ def __lt__(self, other):
+ return (cmp(self.end, other.end)
+ or cmp(hash(self), hash(other))) < 0
+
+ def __le__(self, other):
+ return (cmp(self.end, other.end)
+ or cmp(hash(self), hash(other))) <= 0
+
+ def __gt__(self, other):
+ return (cmp(self.end, other.end)
+ or cmp(hash(self), hash(other))) > 0
+
+ def __ge__(self, other):
+ return (cmp(self.end, other.end)
+ or cmp(hash(self), hash(other))) >= 0
+
def __hash__(self):
- return hash(self.end)
+ raise NotImplementedError
Review comment:
OK thanks, and interesting! So the `NotImplementedError` is only relevant
for the consistency of the `__eq__` but doesn't have an impact for child
classes. Good to know :-)!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 128254)
Time Spent: 12h 20m (was: 12h 10m)
> Futurize and fix python 2 compatibility for transforms subpackage
> -----------------------------------------------------------------
>
> Key: BEAM-4006
> URL: https://issues.apache.org/jira/browse/BEAM-4006
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Matthias Feys
> Priority: Major
> Time Spent: 12h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
