[
https://issues.apache.org/jira/browse/BEAM-5030?focusedWorklogId=131298&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-131298
]
ASF GitHub Bot logged work on BEAM-5030:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Aug/18 03:15
Start Date: 06/Aug/18 03:15
Worklog Time Spent: 10m
Work Description: holdenk commented on issue #6102: [BEAM-5030]
Consolidate defer overhead per bundle
URL: https://github.com/apache/beam/pull/6102#issuecomment-410577517
cc @herohde do you have time for a once over?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 131298)
Time Spent: 40m (was: 0.5h)
> Consolidate defer overhead per bundle
> -------------------------------------
>
> Key: BEAM-5030
> URL: https://issues.apache.org/jira/browse/BEAM-5030
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Robert Burke
> Assignee: Robert Burke
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> At present, reflectx.CallNoPanic is invoked for every element, and addsÂ
> recovery defers for each element. Defers are cheap, but not "per element"
> cheap. In a simple pipeline (a single ParDo), this represents around ~3%
> overhead for the pipeline, which is aggravated for every pardo layer.
> Since the beam model's unit of re-triable computation is per bundle, the
> recovery defers should be invoked per bundle only at the root. This is
> already being done in
> [exec/plan.go|https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/core/runtime/exec/plan.go#L112]
> This could be as simple as calling Call directly in
> [exec/fn.go|https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/core/runtime/exec/fn.go#L99]
> instead of with the reflectx wrapper as it is presently.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
