[
https://issues.apache.org/jira/browse/BEAM-5030?focusedWorklogId=131448&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-131448
]
ASF GitHub Bot logged work on BEAM-5030:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Aug/18 15:56
Start Date: 06/Aug/18 15:56
Worklog Time Spent: 10m
Work Description: herohde closed pull request #6102: [BEAM-5030]
Consolidate defer overhead per bundle
URL: https://github.com/apache/beam/pull/6102
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/sdks/go/pkg/beam/core/runtime/exec/fn.go
b/sdks/go/pkg/beam/core/runtime/exec/fn.go
index 796a871f7e5..23d7bbe583f 100644
--- a/sdks/go/pkg/beam/core/runtime/exec/fn.go
+++ b/sdks/go/pkg/beam/core/runtime/exec/fn.go
@@ -25,7 +25,6 @@ import (
"github.com/apache/beam/sdks/go/pkg/beam/core/graph/mtime"
"github.com/apache/beam/sdks/go/pkg/beam/core/graph/window"
"github.com/apache/beam/sdks/go/pkg/beam/core/typex"
- "github.com/apache/beam/sdks/go/pkg/beam/core/util/reflectx"
)
// MainInput is the main input and is unfolded in the invocation, if present.
@@ -150,10 +149,7 @@ func (n *invoker) Invoke(ctx context.Context, ws
[]typex.Window, ts typex.EventT
}
// (4) Invoke
- ret, err := reflectx.CallNoPanic(fn.Fn, args)
- if err != nil {
- return nil, err
- }
+ ret := fn.Fn.Call(args)
if n.errIdx >= 0 && ret[n.errIdx] != nil {
return nil, ret[n.errIdx].(error)
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 131448)
Time Spent: 50m (was: 40m)
> Consolidate defer overhead per bundle
> -------------------------------------
>
> Key: BEAM-5030
> URL: https://issues.apache.org/jira/browse/BEAM-5030
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Robert Burke
> Assignee: Robert Burke
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> At present, reflectx.CallNoPanic is invoked for every element, and addsÂ
> recovery defers for each element. Defers are cheap, but not "per element"
> cheap. In a simple pipeline (a single ParDo), this represents around ~3%
> overhead for the pipeline, which is aggravated for every pardo layer.
> Since the beam model's unit of re-triable computation is per bundle, the
> recovery defers should be invoked per bundle only at the root. This is
> already being done in
> [exec/plan.go|https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/core/runtime/exec/plan.go#L112]
> This could be as simple as calling Call directly in
> [exec/fn.go|https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/core/runtime/exec/fn.go#L99]
> instead of with the reflectx wrapper as it is presently.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
