[
https://issues.apache.org/jira/browse/BEAM-5041?focusedWorklogId=131544&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-131544
]
ASF GitHub Bot logged work on BEAM-5041:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Aug/18 19:50
Start Date: 06/Aug/18 19:50
Worklog Time Spent: 10m
Work Description: lukecwik commented on issue #6093: [BEAM-5041] Java Fn
SDK Harness use pTransform to track processed graph
URL: https://github.com/apache/beam/pull/6093#issuecomment-410831830
This change looks good to me. Thanks for figuring out the flaw in the
existing logic since it assumed consumers were only added to the current
PCollection that was being iterated over.
Ben, IMO the validates runner test is a better was to make sure that end to
end this isn't broken across runners.
I looked at the Python SDK and it builds the transforms by using the
topological height of the transforms. We could do something very similar and
rely on `QueryablePipeline#getTopologicallyOrderedTransforms` instead of the
current recursive descent logic. This would be a good follow up change if your
interested.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 131544)
Time Spent: 1.5h (was: 1h 20m)
> Java Fn SDK Harness skips unprocessed pCollections
> --------------------------------------------------
>
> Key: BEAM-5041
> URL: https://issues.apache.org/jira/browse/BEAM-5041
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-harness
> Reporter: Ankur Goenka
> Assignee: Ankur Goenka
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Java Sdk Harness used pCollections to keep track of computed consumers
> [here|https://github.com/apache/beam/blob/ff95a82e461bd8319d9733be60e75992ba90cd7c/sdks/java/harness/src/main/java/org/apache/beam/fn/harness/control/ProcessBundleHandler.java#L158].
> This is incorrect as consumers are based on pTransforms so pTransforms
> should be used to keep track of computed consumers.
> In case of Flatten, this creates an issue where pTransforms having same input
> as that to flatten are not executed. This causes
> [https://github.com/apache/beam/blob/ff95a82e461bd8319d9733be60e75992ba90cd7c/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/FlattenTest.java#L316]
> to fail.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
