[
https://issues.apache.org/jira/browse/BEAM-5041?focusedWorklogId=131550&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-131550
]
ASF GitHub Bot logged work on BEAM-5041:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Aug/18 19:59
Start Date: 06/Aug/18 19:59
Worklog Time Spent: 10m
Work Description: angoenka commented on issue #6093: [BEAM-5041] Java Fn
SDK Harness use pTransform to track processed graph
URL: https://github.com/apache/beam/pull/6093#issuecomment-410834528
Yes, Topological sort is a better way to tackle this issue in more logical
manner. Current implementation is very close to what topological sort would do
but as we already have means to do topological sort, we should use
`QueryablePipeline#getTopologicallyOrderedTransforms`
Jira to track this https://issues.apache.org/jira/browse/BEAM-5090
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 131550)
Time Spent: 1h 50m (was: 1h 40m)
> Java Fn SDK Harness skips unprocessed pCollections
> --------------------------------------------------
>
> Key: BEAM-5041
> URL: https://issues.apache.org/jira/browse/BEAM-5041
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-harness
> Reporter: Ankur Goenka
> Assignee: Ankur Goenka
> Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Java Sdk Harness used pCollections to keep track of computed consumers
> [here|https://github.com/apache/beam/blob/ff95a82e461bd8319d9733be60e75992ba90cd7c/sdks/java/harness/src/main/java/org/apache/beam/fn/harness/control/ProcessBundleHandler.java#L158].
> This is incorrect as consumers are based on pTransforms so pTransforms
> should be used to keep track of computed consumers.
> In case of Flatten, this creates an issue where pTransforms having same input
> as that to flatten are not executed. This causes
> [https://github.com/apache/beam/blob/ff95a82e461bd8319d9733be60e75992ba90cd7c/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/FlattenTest.java#L316]
> to fail.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
