[
https://issues.apache.org/jira/browse/BEAM-4780?focusedWorklogId=131632&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-131632
]
ASF GitHub Bot logged work on BEAM-4780:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Aug/18 22:32
Start Date: 06/Aug/18 22:32
Worklog Time Spent: 10m
Work Description: youngoli commented on a change in pull request #6151:
[BEAM-4780] Updating to DockerJobBundleFactory in ReferenceRunner.
URL: https://github.com/apache/beam/pull/6151#discussion_r208048735
##########
File path:
runners/direct-java/src/main/java/org/apache/beam/runners/direct/portable/ReferenceRunner.java
##########
@@ -168,6 +170,7 @@ public void execute() throws Exception {
.setWorkerId("foo")
.setResourceLimits(Resources.getDefaultInstance())
.build();
+ JobInfo jobInfo = JobInfo.create("id", "reference", "retrieval-token",
options);
Review comment:
Good point. I think it's a bit outside the scope of this PR, but I wrote a
bug and added a TODO so I can look into it later.
Since this PR right now is mainly for trying to get #6073 working I don't
really want to spend too long working on the JobInfo yet (although I will
almost certainly need to get to it at some point).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 131632)
Time Spent: 40m (was: 0.5h)
> Entry point for ULR JobService compatible with TestPortableRunner
> -----------------------------------------------------------------
>
> Key: BEAM-4780
> URL: https://issues.apache.org/jira/browse/BEAM-4780
> Project: Beam
> Issue Type: Bug
> Components: runner-direct
> Reporter: Eugene Kirpichov
> Assignee: Daniel Oliveira
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> [https://github.com/apache/beam/pull/5935] introduces a TestPortableRunner
> that can run ValidatesRunner tests against a given portable runner,
> identified by a class name of a shim that can start/stop its JobService
> endpoint.
> For ULR to run VR tests, it needs to provide such a shim.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
