[
https://issues.apache.org/jira/browse/BEAM-4679?focusedWorklogId=131648&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-131648
]
ASF GitHub Bot logged work on BEAM-4679:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Aug/18 23:05
Start Date: 06/Aug/18 23:05
Worklog Time Spent: 10m
Work Description: youngoli commented on issue #6141: [BEAM-4679]
Re-adding Flatten roots in ULR.
URL: https://github.com/apache/beam/pull/6141#issuecomment-410880263
> Do we also need to add other primitive transforms here?
Reference:
https://github.com/apache/beam/blob/master/runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkBatchPortablePipelineTranslator.java#L133
I don't think that's necessary. This class only handles providers for roots
of the pipeline. Theoretically only the ImpulseProvider should be necessary,
but Java pipelines allow Flattens as roots, so to get the ValidatesRunner tests
around that working this needed to be added.
Basically, I'm trying to avoid adding anything unless the ValidatesRunner
tests fail otherwise.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 131648)
Time Spent: 1.5h (was: 1h 20m)
> Support portable combiner lifting in Java Reference Runner
> ----------------------------------------------------------
>
> Key: BEAM-4679
> URL: https://issues.apache.org/jira/browse/BEAM-4679
> Project: Beam
> Issue Type: Sub-task
> Components: runner-direct
> Reporter: Daniel Oliveira
> Assignee: Daniel Oliveira
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Adjust the Reference Runner in Java to support portable combiner lifting as
> described in the following doc:
> https://s.apache.org/beam-runner-api-combine-model
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
