[
https://issues.apache.org/jira/browse/BEAM-4679?focusedWorklogId=132758&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-132758
]
ASF GitHub Bot logged work on BEAM-4679:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Aug/18 23:03
Start Date: 08/Aug/18 23:03
Worklog Time Spent: 10m
Work Description: angoenka commented on a change in pull request #6141:
[BEAM-4679] Re-adding Flatten roots in ULR.
URL: https://github.com/apache/beam/pull/6141#discussion_r208762489
##########
File path:
runners/direct-java/src/main/java/org/apache/beam/runners/direct/portable/RootProviderRegistry.java
##########
@@ -18,28 +18,28 @@
package org.apache.beam.runners.direct.portable;
import static com.google.common.base.Preconditions.checkNotNull;
+import static
org.apache.beam.runners.core.construction.PTransformTranslation.FLATTEN_TRANSFORM_URN;
import static
org.apache.beam.runners.core.construction.PTransformTranslation.IMPULSE_TRANSFORM_URN;
import com.google.common.collect.ImmutableMap;
import java.util.Collection;
import java.util.Map;
import org.apache.beam.runners.core.construction.PTransformTranslation;
import
org.apache.beam.runners.core.construction.graph.PipelineNode.PTransformNode;
-import org.apache.beam.sdk.transforms.Impulse;
import org.apache.beam.sdk.transforms.PTransform;
/**
* A {@link RootInputProvider} that delegates to primitive {@link
RootInputProvider} implementations
* based on the type of {@link PTransform} of the application.
*/
class RootProviderRegistry {
- /** Returns a {@link RootProviderRegistry} that only supports the {@link
Impulse} primitive. */
- public static RootProviderRegistry impulseRegistry(BundleFactory
bundleFactory) {
+ static RootProviderRegistry javaPortableRegistry(BundleFactory
bundleFactory) {
Review comment:
nit: java doc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 132758)
Time Spent: 1h 50m (was: 1h 40m)
> Support portable combiner lifting in Java Reference Runner
> ----------------------------------------------------------
>
> Key: BEAM-4679
> URL: https://issues.apache.org/jira/browse/BEAM-4679
> Project: Beam
> Issue Type: Sub-task
> Components: runner-direct
> Reporter: Daniel Oliveira
> Assignee: Daniel Oliveira
> Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Adjust the Reference Runner in Java to support portable combiner lifting as
> described in the following doc:
> https://s.apache.org/beam-runner-api-combine-model
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
