[
https://issues.apache.org/jira/browse/BEAM-3026?focusedWorklogId=132387&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-132387
]
ASF GitHub Bot logged work on BEAM-3026:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Aug/18 14:30
Start Date: 08/Aug/18 14:30
Worklog Time Spent: 10m
Work Description: aalbatross commented on issue #6146: [BEAM-3026] Adding
retrying behavior on ElasticSearchIO
URL: https://github.com/apache/beam/pull/6146#issuecomment-411426638
Tim thank you for reviewing this quickly. I have added the changes as you
commented.
I am not going for the autovalue/ builder approach now as we spent lot of
time doing code change and review using the current approach i do not think it
would be great to change the entire approach now and have fresh changes again.
But if you think it is necessary for any important reasons i will change
them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 132387)
Time Spent: 5h 20m (was: 5h 10m)
> Improve retrying in ElasticSearch client
> ----------------------------------------
>
> Key: BEAM-3026
> URL: https://issues.apache.org/jira/browse/BEAM-3026
> Project: Beam
> Issue Type: Improvement
> Components: io-java-elasticsearch
> Reporter: Tim Robertson
> Assignee: Ravi Pathak
> Priority: Major
> Fix For: 2.7.0
>
> Time Spent: 5h 20m
> Remaining Estimate: 0h
>
> Currently an overloaded ES server will result in clients failing fast.
> I suggest implementing backoff pauses. Perhaps something like this:
> {code}
> ElasticsearchIO.ConnectionConfiguration conn =
> ElasticsearchIO.ConnectionConfiguration
> .create(new String[]{"http://...:9200"}, "test", "test")
> .retryWithWaitStrategy(WaitStrategies.exponentialBackoff(1000,
> TimeUnit.MILLISECONDS)
> .retryWithStopStrategy(StopStrategies.stopAfterAttempt(10)
> );
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
