[
https://issues.apache.org/jira/browse/BEAM-3026?focusedWorklogId=132552&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-132552
]
ASF GitHub Bot logged work on BEAM-3026:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Aug/18 19:05
Start Date: 08/Aug/18 19:05
Worklog Time Spent: 10m
Work Description: timrobertson100 edited a comment on issue #6146:
[BEAM-3026] Adding retrying behavior on ElasticSearchIO
URL: https://github.com/apache/beam/pull/6146#issuecomment-411517540
Thanks @aalbatross for incorporating the change requests.
I'm -0 on the common configuration (doesn't add much of benefit, spreads
otherwise encapsulated code over packages, likely more total lines of code,
inconsistent compared to other IO) but I recognise this is subjective and the
implementation doesn't expose more configurable parameters than desired.
@jbonofre can you PTAL?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 132552)
Time Spent: 6h (was: 5h 50m)
> Improve retrying in ElasticSearch client
> ----------------------------------------
>
> Key: BEAM-3026
> URL: https://issues.apache.org/jira/browse/BEAM-3026
> Project: Beam
> Issue Type: Improvement
> Components: io-java-elasticsearch
> Reporter: Tim Robertson
> Assignee: Ravi Pathak
> Priority: Major
> Fix For: 2.7.0
>
> Time Spent: 6h
> Remaining Estimate: 0h
>
> Currently an overloaded ES server will result in clients failing fast.
> I suggest implementing backoff pauses. Perhaps something like this:
> {code}
> ElasticsearchIO.ConnectionConfiguration conn =
> ElasticsearchIO.ConnectionConfiguration
> .create(new String[]{"http://...:9200"}, "test", "test")
> .retryWithWaitStrategy(WaitStrategies.exponentialBackoff(1000,
> TimeUnit.MILLISECONDS)
> .retryWithStopStrategy(StopStrategies.stopAfterAttempt(10)
> );
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
