[
https://issues.apache.org/jira/browse/BEAM-5107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16577690#comment-16577690
]
Tim Robertson commented on BEAM-5107:
-------------------------------------
Thank you for the pull request [~dattran.vn01].
If you could explore tests for the changes you provided in the first PR that
would be great. Beam favours embedded servers for unit tests, and then ES also
has a suite of integration tests.
I am not sure what will happen when you put a ES6 on the classpath though for a
unit test. It could be that you simply can't do that, and if so I'd suggest 1)
doing an integration test copying the existing ones (without the "type" test)
to demonstrate that it works and 2) documenting in the JDoc that the IO uses
ES5 clients but is known to work with ES6. It's not ideal but will get ES6
support into Beam and we can set up the IT to run regularly to give confidence
it all works.
Can you please try and include a test that covers the withIDFn and withIndexFn
for ES6? I see the full addressing test is not supported (ES6 dropping the
ability to dynamically set a type) but the other two are useful.
Please also be aware that the future is likely to be built around the BEAM-3199
version since it makes use of the newest ES client (RestHighLevelClient).
> Support ES 6.x for ElasticsearchIO
> ----------------------------------
>
> Key: BEAM-5107
> URL: https://issues.apache.org/jira/browse/BEAM-5107
> Project: Beam
> Issue Type: Improvement
> Components: io-java-elasticsearch
> Reporter: Dat Tran
> Assignee: Etienne Chauchot
> Priority: Minor
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Elasticsearch has released 6.3.2 but ElasticsearchIO only supports 2x-5.x.
> We should support ES 6.x for ElasticsearchIO.
> https://www.elastic.co/guide/en/elasticsearch/reference/current/index.html
> https://github.com/apache/beam/blob/master/sdks/java/io/elasticsearch/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIO.java
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
