[ 
https://issues.apache.org/jira/browse/BEAM-5107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16577803#comment-16577803
 ] 

Dat Tran commented on BEAM-5107:
--------------------------------

Thank you [~timrobertson100] for your suggestion and support.

I committed some changes to my PR
 * update build.gradle of beam-sdks-java-io-elasticsearch to ES 6.3.2
 * clone beam-sdks-java-io-elasticsearch-tests-6 from 
beam-sdks-java-io-elasticsearch-tests-5 and update JarHell. I see the full 
addressing test is working in beam-sdks-java-io-elasticsearch-tests-6 so we 
don't need to add new tests to cover the withIDFn and withIndexFn
 * rollback beam-sdks-java-io-elasticsearch-tests-5

I see only testWriteWithTypeFn does not work with ES 6. The rest tests still 
work with ES 6

I like to have only one ElasticserachIO supports 3 main ES version (2.x, 5,x, 
6.x) because I'm working in one Google Dataflow (Java beam) project that 
requires to support many ES versions in one code base.I need to sink data to 
old ES to support legacy application and sink data to new ES to support new 
application.

RestHighLevelClient is really nice. I will ask Jeroen  if he welcomes help.

 

 

> Support ES 6.x for ElasticsearchIO
> ----------------------------------
>
>                 Key: BEAM-5107
>                 URL: https://issues.apache.org/jira/browse/BEAM-5107
>             Project: Beam
>          Issue Type: Improvement
>          Components: io-java-elasticsearch
>            Reporter: Dat Tran
>            Assignee: Etienne Chauchot
>            Priority: Minor
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> Elasticsearch has released 6.3.2 but ElasticsearchIO only supports 2x-5.x.
> We should support ES 6.x for ElasticsearchIO.
> https://www.elastic.co/guide/en/elasticsearch/reference/current/index.html
> https://github.com/apache/beam/blob/master/sdks/java/io/elasticsearch/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIO.java



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to