[ 
https://issues.apache.org/jira/browse/BEAM-2930?focusedWorklogId=137801&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-137801
 ]

ASF GitHub Bot logged work on BEAM-2930:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 24/Aug/18 13:21
            Start Date: 24/Aug/18 13:21
    Worklog Time Spent: 10m 
      Work Description: mxm commented on a change in pull request #6208: 
[BEAM-2930] Side input support for Flink portable streaming.
URL: https://github.com/apache/beam/pull/6208#discussion_r212317984
 
 

 ##########
 File path: 
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkBatchPortablePipelineTranslator.java
 ##########
 @@ -149,6 +149,7 @@ public static FlinkBatchPortablePipelineTranslator 
createTranslator() {
     translatorMap.put(
         PTransformTranslation.RESHUFFLE_URN,
         FlinkBatchPortablePipelineTranslator::translateReshuffle);
+    // TODO: this does not seem required
     translatorMap.put(
         PTransformTranslation.CREATE_VIEW_TRANSFORM_URN,
         FlinkBatchPortablePipelineTranslator::translateView);
 
 Review comment:
   Not sure if that always work, e.g. when the input stream of the view is not 
already added by another transform?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 137801)
    Time Spent: 4h 40m  (was: 4.5h)

> Flink support for portable side input
> -------------------------------------
>
>                 Key: BEAM-2930
>                 URL: https://issues.apache.org/jira/browse/BEAM-2930
>             Project: Beam
>          Issue Type: Sub-task
>          Components: runner-flink
>            Reporter: Henning Rohde
>            Assignee: Thomas Weise
>            Priority: Major
>              Labels: portability
>          Time Spent: 4h 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to