[ 
https://issues.apache.org/jira/browse/BEAM-2930?focusedWorklogId=137861&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-137861
 ]

ASF GitHub Bot logged work on BEAM-2930:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 24/Aug/18 15:55
            Start Date: 24/Aug/18 15:55
    Worklog Time Spent: 10m 
      Work Description: tweise commented on a change in pull request #6208: 
[BEAM-2930] Side input support for Flink portable streaming.
URL: https://github.com/apache/beam/pull/6208#discussion_r212674746
 
 

 ##########
 File path: 
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkStreamingPortablePipelineTranslator.java
 ##########
 @@ -520,6 +567,158 @@ private void translateImpulse(
     }
   }
 
+  private static LinkedHashMap<RunnerApi.ExecutableStagePayload.SideInputId, 
PCollectionView<?>>
+      getSideInputIdToPCollectionViewMap(
+          RunnerApi.ExecutableStagePayload stagePayload, RunnerApi.Components 
components) {
+
+    RehydratedComponents rehydratedComponents = 
RehydratedComponents.forComponents(components);
+
+    LinkedHashMap<RunnerApi.ExecutableStagePayload.SideInputId, 
PCollectionView<?>> sideInputs =
+        new LinkedHashMap<>();
+    for (RunnerApi.ExecutableStagePayload.SideInputId sideInputId :
+        stagePayload.getSideInputsList()) {
+
+      // TODO: local name is unique as long as only one transform with side 
input can be within a stage
+      String sideInputTag = sideInputId.getLocalName();
+      // for PCollectionView compatibility, not used to transform 
materialization
+      ViewFn<Iterable<WindowedValue<?>>, ?> viewFn =
+          (ViewFn) new 
PCollectionViews.MultimapViewFn<Iterable<WindowedValue<Void>>, Void>();
 
 Review comment:
   done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 137861)
    Time Spent: 6h  (was: 5h 50m)

> Flink support for portable side input
> -------------------------------------
>
>                 Key: BEAM-2930
>                 URL: https://issues.apache.org/jira/browse/BEAM-2930
>             Project: Beam
>          Issue Type: Sub-task
>          Components: runner-flink
>            Reporter: Henning Rohde
>            Assignee: Thomas Weise
>            Priority: Major
>              Labels: portability
>          Time Spent: 6h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to