[
https://issues.apache.org/jira/browse/BEAM-4461?focusedWorklogId=142080&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-142080
]
ASF GitHub Bot logged work on BEAM-4461:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Sep/18 07:59
Start Date: 07/Sep/18 07:59
Worklog Time Spent: 10m
Work Description: reuvenlax commented on a change in pull request #6318:
[BEAM-4461] Some fixes to Combiners needed for Schema support.
URL: https://github.com/apache/beam/pull/6318#discussion_r215876304
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/CombineFns.java
##########
@@ -470,7 +589,10 @@ public CoCombineResult extractOutput(Object[]
accumulator, Context c) {
throws CannotProvideCoderException {
List<Coder<Object>> coders = Lists.newArrayList();
for (int i = 0; i < combineFnCount; ++i) {
- Coder<Object> inputCoder =
registry.getOutputCoder(extractInputFns.get(i), dataCoder);
+ Coder<Object> inputCoder =
+ combineInputCoders.get(i).isPresent()
Review comment:
Unfortunately the get.or method won't work here, since it's type signature
can't handle functions that throw exceptions (such as
CannotProvideCoderExceptions).
As to the second, I don't think the registry is available at that time the
combiner is built up. The registry is generally not available until later in
pipeline construction, and the Combiner signature doesn't give it to us until
getAccumulatorCoder is called.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 142080)
Time Spent: 6h (was: 5h 50m)
> Create a library of useful transforms that use schemas
> ------------------------------------------------------
>
> Key: BEAM-4461
> URL: https://issues.apache.org/jira/browse/BEAM-4461
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-core
> Reporter: Reuven Lax
> Assignee: Reuven Lax
> Priority: Major
> Time Spent: 6h
> Remaining Estimate: 0h
>
> e.g. JoinBy(fields). Project, Filter, etc.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
