[ 
https://issues.apache.org/jira/browse/BEAM-4176?focusedWorklogId=142191&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-142191
 ]

ASF GitHub Bot logged work on BEAM-4176:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 07/Sep/18 14:13
            Start Date: 07/Sep/18 14:13
    Worklog Time Spent: 10m 
      Work Description: tweise commented on issue #6328: [BEAM-4176] enumerate 
primitive transforms in portable construction
URL: https://github.com/apache/beam/pull/6328#issuecomment-419452647
 
 
   @lukecwik this is probably something we should take to the mailing list for 
broader visibility. Currently the Flink runner does the pipeline surgery before 
translation. With the proposed change the customization referenced above would 
need to spread over multiple components (fuser/prep and translator) while it's 
encapsulated in a single place now.
   
   In the example the Flink sources really are primitives that should remain 
handled on the runner side as such (effectively like ParDo without inputs). 
Would it perhaps also make sense to assume that as a default when our common 
fusion code does not recognize a URN? If I was to introduce a custom URN that 
requires fusion break, then yes, it would be necessary to provide that 
information to the fuser. That seems cleaner than the runner temporarily 
switching URNs to appease the fuser.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 142191)
    Time Spent: 18h 40m  (was: 18.5h)

> Java: Portable batch runner passes all ValidatesRunner tests that 
> non-portable runner passes
> --------------------------------------------------------------------------------------------
>
>                 Key: BEAM-4176
>                 URL: https://issues.apache.org/jira/browse/BEAM-4176
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-flink
>            Reporter: Ben Sidhom
>            Priority: Major
>         Attachments: Screen Shot 2018-08-14 at 4.18.31 PM.png, Screen Shot 
> 2018-09-03 at 11.07.38 AM.png
>
>          Time Spent: 18h 40m
>  Remaining Estimate: 0h
>
> We need this as a sanity check that runner execution is correct.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to