[
https://issues.apache.org/jira/browse/BEAM-4176?focusedWorklogId=145380&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-145380
]
ASF GitHub Bot logged work on BEAM-4176:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Sep/18 17:17
Start Date: 18/Sep/18 17:17
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #6328:
[BEAM-4176] enumerate primitive transforms in portable construction
URL: https://github.com/apache/beam/pull/6328#discussion_r218520440
##########
File path:
runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/NativeTransformsTest.java
##########
@@ -39,14 +40,15 @@ public boolean test(RunnerApi.PTransform pTransform) {
@Test
public void testMatch() {
- NativeTransforms.isNative(
- RunnerApi.PTransform.newBuilder()
-
.setSpec(RunnerApi.FunctionSpec.newBuilder().setUrn("test").build())
- .build());
+ Assert.assertTrue(
Review comment:
What a silly mistake I made
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 145380)
Time Spent: 20h (was: 19h 50m)
> Java: Portable batch runner passes all ValidatesRunner tests that
> non-portable runner passes
> --------------------------------------------------------------------------------------------
>
> Key: BEAM-4176
> URL: https://issues.apache.org/jira/browse/BEAM-4176
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Reporter: Ben Sidhom
> Priority: Major
> Attachments: Screen Shot 2018-08-14 at 4.18.31 PM.png, Screen Shot
> 2018-09-03 at 11.07.38 AM.png
>
> Time Spent: 20h
> Remaining Estimate: 0h
>
> We need this as a sanity check that runner execution is correct.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
