[
https://issues.apache.org/jira/browse/BEAM-4461?focusedWorklogId=147561&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-147561
]
ASF GitHub Bot logged work on BEAM-4461:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Sep/18 13:37
Start Date: 25/Sep/18 13:37
Worklog Time Spent: 10m
Work Description: akedin commented on a change in pull request #6298:
[BEAM-4461] Introduce Group transform.
URL: https://github.com/apache/beam/pull/6298#discussion_r220186019
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/coders/RowCoder.java
##########
@@ -116,16 +117,53 @@ public Schema getSchema() {
@Override
public void verifyDeterministic()
- throws org.apache.beam.sdk.coders.Coder.NonDeterministicException {}
+ throws org.apache.beam.sdk.coders.Coder.NonDeterministicException {
+ verifyDeterministic(schema);
+ }
+
+ private void verifyDeterministic(Schema schema)
+ throws org.apache.beam.sdk.coders.Coder.NonDeterministicException {
+ for (Field field : schema.getFields()) {
+ verifyDeterministic(field.getType());
+ }
+ }
+
+ private void verifyDeterministic(FieldType fieldType)
+ throws org.apache.beam.sdk.coders.Coder.NonDeterministicException {
+ switch (fieldType.getTypeName()) {
+ case MAP:
+ throw new NonDeterministicException(this, "Map-valued fields cannot be
used in keys");
Review comment:
Why is this? Can you explain more in the message?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 147561)
Time Spent: 10h 40m (was: 10.5h)
> Create a library of useful transforms that use schemas
> ------------------------------------------------------
>
> Key: BEAM-4461
> URL: https://issues.apache.org/jira/browse/BEAM-4461
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-core
> Reporter: Reuven Lax
> Assignee: Reuven Lax
> Priority: Major
> Time Spent: 10h 40m
> Remaining Estimate: 0h
>
> e.g. JoinBy(fields). Project, Filter, etc.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
