[ https://issues.apache.org/jira/browse/BEAM-4461?focusedWorklogId=151693&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-151693 ]
ASF GitHub Bot logged work on BEAM-4461: ---------------------------------------- Author: ASF GitHub Bot Created on: 05/Oct/18 16:59 Start Date: 05/Oct/18 16:59 Worklog Time Spent: 10m Work Description: akedin commented on a change in pull request #6298: [BEAM-4461] Introduce Group transform. URL: https://github.com/apache/beam/pull/6298#discussion_r223074665 ########## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/values/PCollection.java ########## @@ -330,6 +330,24 @@ public Schema getSchema() { return ((SchemaCoder) getCoder()).getSchema(); } + /** Returns the attached schema's toRowFunction. */ + @Experimental(Kind.SCHEMAS) + public SerializableFunction<T, Row> getToRowFunction() { Review comment: I think this doesn't belong on `PCollection`, they're not a property of it. I'd rather have something like `T getCoder(Class<T>)` overload to help with casting ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 151693) > Create a library of useful transforms that use schemas > ------------------------------------------------------ > > Key: BEAM-4461 > URL: https://issues.apache.org/jira/browse/BEAM-4461 > Project: Beam > Issue Type: Sub-task > Components: sdk-java-core > Reporter: Reuven Lax > Assignee: Reuven Lax > Priority: Major > Time Spent: 12h 20m > Remaining Estimate: 0h > > e.g. JoinBy(fields). Project, Filter, etc. -- This message was sent by Atlassian JIRA (v7.6.3#76005)