[
https://issues.apache.org/jira/browse/BEAM-5112?focusedWorklogId=147573&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-147573
]
ASF GitHub Bot logged work on BEAM-5112:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Sep/18 13:52
Start Date: 25/Sep/18 13:52
Worklog Time Spent: 10m
Work Description: akedin commented on a change in pull request #6417:
[BEAM-5112] Use Calcite codegen to implement BeamCalcRel
URL: https://github.com/apache/beam/pull/6417#discussion_r220201064
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamCalcRel.java
##########
@@ -58,8 +98,19 @@ public Calc copy(RelTraitSet traitSet, RelNode input,
RexProgram program) {
return new Transform();
}
+ private static final Map<TypeName, Type> rawTypeMap =
+ ImmutableMap.<TypeName, Type>builder()
+ .put(TypeName.BYTE, Byte.class)
+ .put(TypeName.INT16, Short.class)
+ .put(TypeName.INT32, Integer.class)
+ .put(TypeName.INT64, Long.class)
+ .put(TypeName.FLOAT, Float.class)
+ .put(TypeName.DOUBLE, Double.class)
+ .build();
+
private class Transform extends PTransform<PCollectionList<Row>,
PCollection<Row>> {
+ /** expand is based on calcite's EnumerableCalc.implement(). */
Review comment:
Can you add a description of how stuff works here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 147573)
Time Spent: 20m (was: 10m)
> Investigate if Calcite can generate functions that we need
> ----------------------------------------------------------
>
> Key: BEAM-5112
> URL: https://issues.apache.org/jira/browse/BEAM-5112
> Project: Beam
> Issue Type: Sub-task
> Components: dsl-sql
> Reporter: Rui Wang
> Assignee: Andrew Pilloud
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
