[
https://issues.apache.org/jira/browse/BEAM-5112?focusedWorklogId=147576&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-147576
]
ASF GitHub Bot logged work on BEAM-5112:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Sep/18 13:52
Start Date: 25/Sep/18 13:52
Worklog Time Spent: 10m
Work Description: akedin commented on a change in pull request #6417:
[BEAM-5112] Use Calcite codegen to implement BeamCalcRel
URL: https://github.com/apache/beam/pull/6417#discussion_r220196776
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/planner/BeamRelDataTypeSystem.java
##########
@@ -35,4 +35,9 @@ public int getMaxNumericScale() {
public int getMaxNumericPrecision() {
return 38;
}
+
+ @Override
+ public boolean shouldConvertRaggedUnionTypesToVarying() {
+ return true;
Review comment:
nit: we should add comments about why all the stuff in this class is set to
these values
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 147576)
Time Spent: 0.5h (was: 20m)
> Investigate if Calcite can generate functions that we need
> ----------------------------------------------------------
>
> Key: BEAM-5112
> URL: https://issues.apache.org/jira/browse/BEAM-5112
> Project: Beam
> Issue Type: Sub-task
> Components: dsl-sql
> Reporter: Rui Wang
> Assignee: Andrew Pilloud
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
