[
https://issues.apache.org/jira/browse/BEAM-5366?focusedWorklogId=148410&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-148410
]
ASF GitHub Bot logged work on BEAM-5366:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Sep/18 21:54
Start Date: 26/Sep/18 21:54
Worklog Time Spent: 10m
Work Description: lukecwik opened a new pull request #6499: [BEAM-5366]
Vendor gRPC and its transitive dependencies as a separate package.
URL: https://github.com/apache/beam/pull/6499
This prevents beam-model-pipeline, beam-model-fn-execution and
beam-model-job...
from having copies of gRPC and their transitive dependencies being published
as artifacts within Apache Beam.
Note that this is known to break the Dataflow import process since we
are defining a new Gradle project and can only be fixed up during
the actual import.
------------------------
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
It will help us expedite review of your Pull Request if you tag someone
(e.g. `@username`) to look at it.
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/)
| --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/)
| --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)
</br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/)
| --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 148410)
Time Spent: 10m
Remaining Estimate: 0h
> Vendor gRPC and Protobuf separately from beam-model-* Java packages
> -------------------------------------------------------------------
>
> Key: BEAM-5366
> URL: https://issues.apache.org/jira/browse/BEAM-5366
> Project: Beam
> Issue Type: Improvement
> Components: beam-model, build-system
> Reporter: Luke Cwik
> Assignee: Luke Cwik
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Each of the beam-model-* jars currently contains duplicate definitions of
> gRPC and protobuf and their transitive dependencies.
>
> By migrating those packages to a separate artifact, we could have a single
> copy of those classes instead of 3.
>
> This would reduce the size of the jars and prevent warnings such as:
>
> {code:java}
> [WARNING] beam-model-fn-execution-2.5.0.jar,
> beam-model-job-management-2.5.0.jar, beam-model-pipeline-2.5.0.jar define
> 6660 overlapping classes: [WARNING] -
> org.apache.beam.vendor.netty.v4.io.netty.handler.codec.http.HttpClientCodec$1
> [WARNING] -
> org.apache.beam.vendor.guava.v20.com.google.common.util.concurrent.AggregateFutureState$SafeAtomicHelper
> [WARNING] -
> org.apache.beam.vendor.netty.v4.io.netty.util.concurrent.DefaultFutureListeners
> [WARNING] -
> org.apache.beam.vendor.netty.v4.io.netty.handler.ssl.OpenSslSessionContext$1
> [WARNING] -
> org.apache.beam.vendor.netty.v4.io.netty.handler.ssl.Java9SslUtils$4
> [WARNING] -
> org.apache.beam.vendor.guava.v20.com.google.common.collect.ImmutableMultimap$Builder
> [WARNING] -
> org.apache.beam.vendor.netty.v4.io.netty.handler.codec.spdy.SpdyHeaders
> [WARNING] -
> org.apache.beam.vendor.protobuf.v3.com.google.protobuf.DescriptorProtos$FieldDescriptorProtoOrBuilder
> [WARNING] -
> org.apache.beam.vendor.guava.v20.com.google.common.collect.AbstractMultimap
> [WARNING] -
> org.apache.beam.vendor.guava.v20.com.google.common.io.BaseEncoding$3{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
