[
https://issues.apache.org/jira/browse/BEAM-5366?focusedWorklogId=148532&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-148532
]
ASF GitHub Bot logged work on BEAM-5366:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Sep/18 00:03
Start Date: 27/Sep/18 00:03
Worklog Time Spent: 10m
Work Description: aaltay commented on issue #6499: [BEAM-5366] Vendor
gRPC and its transitive dependencies as a separate package.
URL: https://github.com/apache/beam/pull/6499#issuecomment-424909202
Thank you both. Please let me know when it is ready to merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 148532)
Time Spent: 50m (was: 40m)
> Vendor gRPC and Protobuf separately from beam-model-* Java packages
> -------------------------------------------------------------------
>
> Key: BEAM-5366
> URL: https://issues.apache.org/jira/browse/BEAM-5366
> Project: Beam
> Issue Type: Improvement
> Components: beam-model, build-system
> Reporter: Luke Cwik
> Assignee: Luke Cwik
> Priority: Minor
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Each of the beam-model-* jars currently contains duplicate definitions of
> gRPC and protobuf and their transitive dependencies.
>
> By migrating those packages to a separate artifact, we could have a single
> copy of those classes instead of 3.
>
> This would reduce the size of the jars and prevent warnings such as:
>
> {code:java}
> [WARNING] beam-model-fn-execution-2.5.0.jar,
> beam-model-job-management-2.5.0.jar, beam-model-pipeline-2.5.0.jar define
> 6660 overlapping classes: [WARNING] -
> org.apache.beam.vendor.netty.v4.io.netty.handler.codec.http.HttpClientCodec$1
> [WARNING] -
> org.apache.beam.vendor.guava.v20.com.google.common.util.concurrent.AggregateFutureState$SafeAtomicHelper
> [WARNING] -
> org.apache.beam.vendor.netty.v4.io.netty.util.concurrent.DefaultFutureListeners
> [WARNING] -
> org.apache.beam.vendor.netty.v4.io.netty.handler.ssl.OpenSslSessionContext$1
> [WARNING] -
> org.apache.beam.vendor.netty.v4.io.netty.handler.ssl.Java9SslUtils$4
> [WARNING] -
> org.apache.beam.vendor.guava.v20.com.google.common.collect.ImmutableMultimap$Builder
> [WARNING] -
> org.apache.beam.vendor.netty.v4.io.netty.handler.codec.spdy.SpdyHeaders
> [WARNING] -
> org.apache.beam.vendor.protobuf.v3.com.google.protobuf.DescriptorProtos$FieldDescriptorProtoOrBuilder
> [WARNING] -
> org.apache.beam.vendor.guava.v20.com.google.common.collect.AbstractMultimap
> [WARNING] -
> org.apache.beam.vendor.guava.v20.com.google.common.io.BaseEncoding$3{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
