[
https://issues.apache.org/jira/browse/BEAM-4501?focusedWorklogId=151682&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-151682
]
ASF GitHub Bot logged work on BEAM-4501:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Oct/18 16:45
Start Date: 05/Oct/18 16:45
Worklog Time Spent: 10m
Work Description: swegner commented on a change in pull request #6533:
[BEAM-4501] Update website contribution and release docs
URL: https://github.com/apache/beam/pull/6533#discussion_r223070024
##########
File path: website/build.gradle
##########
@@ -65,8 +65,12 @@ task createDockerContainer(type: Exec) {
ext.containerId = {
return standardOutput.toString().trim()
}
+ def extraOptions = ''
+ if (project.hasProperty('publishJekyllPort')) {
+ extraOptions = '-p 127.0.0.1:4000:4000'
Review comment:
Can you add a quick comment about what this does? I assume website
contributors are not all Docker fluent (I'm not).
[Docker
docs](https://docs.docker.com/v17.09/engine/reference/commandline/create/)
describe it as "Publish a container’s port(s) to the host", although I don't
find that totally intuitive.
Would it be correct to say something like: "Specify `-PpublishJekyllPort` on
the Gradle commandline to serve the website locally at http://localhost:4000"; ?
Is my understanding correct that if this option isn't specified, the served
website is inaccessible? That seems not very usable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 151682)
Time Spent: 4h 20m (was: 4h 10m)
> Update contribution guide for new website contribution process
> --------------------------------------------------------------
>
> Key: BEAM-4501
> URL: https://issues.apache.org/jira/browse/BEAM-4501
> Project: Beam
> Issue Type: Sub-task
> Components: website
> Reporter: Scott Wegner
> Assignee: Udi Meiri
> Priority: Major
> Labels: beam-site-automation-reliability
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
