[ 
https://issues.apache.org/jira/browse/BEAM-4501?focusedWorklogId=151724&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-151724
 ]

ASF GitHub Bot logged work on BEAM-4501:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 05/Oct/18 17:11
            Start Date: 05/Oct/18 17:11
    Worklog Time Spent: 10m 
      Work Description: udim commented on a change in pull request #6533: 
[BEAM-4501] Update website contribution and release docs
URL: https://github.com/apache/beam/pull/6533#discussion_r223078705
 
 

 ##########
 File path: website/build.gradle
 ##########
 @@ -65,8 +65,12 @@ task createDockerContainer(type: Exec) {
   ext.containerId = {
     return standardOutput.toString().trim()
   }
+  def extraOptions = ''
+  if (project.hasProperty('publishJekyllPort')) {
+    extraOptions = '-p 127.0.0.1:4000:4000'
 
 Review comment:
   I'm not that Gradle fluent. :)
   What I wanted was to set this option for createDockerContainer, but only if 
gradle is asked to run task serveWebsite. So the option wouldn't be set on 
pre/post-commits, where it might cause them to fail (if port 4000 is already 
taken).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 151724)
    Time Spent: 4h 50m  (was: 4h 40m)

> Update contribution guide for new website contribution process
> --------------------------------------------------------------
>
>                 Key: BEAM-4501
>                 URL: https://issues.apache.org/jira/browse/BEAM-4501
>             Project: Beam
>          Issue Type: Sub-task
>          Components: website
>            Reporter: Scott Wegner
>            Assignee: Udi Meiri
>            Priority: Major
>              Labels: beam-site-automation-reliability
>          Time Spent: 4h 50m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to