[
https://issues.apache.org/jira/browse/BEAM-5467?focusedWorklogId=152655&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-152655
]
ASF GitHub Bot logged work on BEAM-5467:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Oct/18 12:09
Start Date: 09/Oct/18 12:09
Worklog Time Spent: 10m
Work Description: mxm commented on a change in pull request #6532:
[BEAM-5467] Use process SDKHarness to run flink PVR tests.
URL: https://github.com/apache/beam/pull/6532#discussion_r223667213
##########
File path: sdks/python/build.gradle
##########
@@ -327,24 +327,35 @@ task hdfsIntegrationTest(dependsOn: 'installGcpTest') {
}
}
+class CompatibilityMatrixConfig {
+ String type
+ String harnessType = "Docker"
+}
+
def flinkCompatibilityMatrix = {
- def type = it
- def name = 'flinkCompatibilityMatrix' + type
+ def config = it ? it as CompatibilityMatrixConfig : new
CompatibilityMatrixConfig()
+ def type = config.type
+ def harnessType = config.harnessType
+ def name = 'flinkCompatibilityMatrix' + type + harnessType
tasks.create(name: name) {
dependsOn 'setupVirtualenv'
- dependsOn ':beam-sdks-python-container:docker'
+ dependsOn 'createProcessWorker'
dependsOn ':beam-runners-flink_2.11-job-server:shadowJar'
+ if (type.toLowerCase() == 'docker')
+ dependsOn ':beam-sdks-python-container:docker'
doLast {
exec {
executable 'sh'
- args '-c', ". ${envdir}/bin/activate && pip install -e . && python -m
apache_beam.runners.portability.flink_runner_test
${project(":beam-runners-flink_2.11-job-server:").shadowJar.archivePath}
${type}"
+ args '-c', ". ${envdir}/bin/activate && pip install -e . && python -m
apache_beam.runners.portability.flink_runner_test
--flink_job_server_jar=${project(":beam-runners-flink_2.11-job-server:").shadowJar.archivePath}
--type=${type} --harness_type=${harnessType}"
}
}
}
}
-flinkCompatibilityMatrix('Batch')
-flinkCompatibilityMatrix('Streaming')
+flinkCompatibilityMatrix(type: 'Batch')
+flinkCompatibilityMatrix(type:'Streaming')
Review comment:
Missing space after colon
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 152655)
> Python Flink ValidatesRunner job fixes
> --------------------------------------
>
> Key: BEAM-5467
> URL: https://issues.apache.org/jira/browse/BEAM-5467
> Project: Beam
> Issue Type: Improvement
> Components: runner-flink
> Reporter: Thomas Weise
> Assignee: Thomas Weise
> Priority: Minor
> Labels: portability-flink
> Time Spent: 4h 50m
> Remaining Estimate: 0h
>
> Add status to README
> Rename script and job for consistency
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
