[
https://issues.apache.org/jira/browse/BEAM-5467?focusedWorklogId=152650&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-152650
]
ASF GitHub Bot logged work on BEAM-5467:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Oct/18 12:09
Start Date: 09/Oct/18 12:09
Worklog Time Spent: 10m
Work Description: mxm commented on a change in pull request #6532:
[BEAM-5467] Use process SDKHarness to run flink PVR tests.
URL: https://github.com/apache/beam/pull/6532#discussion_r223668109
##########
File path: sdks/python/apache_beam/runners/portability/flink_runner_test.py
##########
@@ -34,12 +36,26 @@
# Run as
#
# python -m apache_beam.runners.portability.flink_runner_test \
- # /path/to/job_server.jar \
+ # --flink_job_server_jar=/path/to/job_server.jar \
+ # --type=Batch \
+ # --harness_type=docker \
# [FlinkRunnerTest.test_method, ...]
- flinkJobServerJar = sys.argv.pop(1)
- streaming = sys.argv.pop(1).lower() == 'streaming'
- # This is defined here to only be run when we invoke this file explicitly.
+ parser = argparse.ArgumentParser(add_help=True)
+ parser.add_argument('--flink_job_server_jar',
+ help='Job server jar to submit jobs.')
+ parser.add_argument('--type', default='batch',
+ help='Job type. batch or streaming')
Review comment:
Would make this a boolean parameter called `streaming`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 152650)
> Python Flink ValidatesRunner job fixes
> --------------------------------------
>
> Key: BEAM-5467
> URL: https://issues.apache.org/jira/browse/BEAM-5467
> Project: Beam
> Issue Type: Improvement
> Components: runner-flink
> Reporter: Thomas Weise
> Assignee: Thomas Weise
> Priority: Minor
> Labels: portability-flink
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> Add status to README
> Rename script and job for consistency
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
