[ https://issues.apache.org/jira/browse/BEAM-5621?focusedWorklogId=154010&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-154010 ]
ASF GitHub Bot logged work on BEAM-5621: ---------------------------------------- Author: ASF GitHub Bot Created on: 12/Oct/18 20:26 Start Date: 12/Oct/18 20:26 Worklog Time Spent: 10m Work Description: charlesccychen commented on issue #6602: [BEAM-5621] Fix unorderable types in python 3 URL: https://github.com/apache/beam/pull/6602#issuecomment-429452434 Because we now sort by types, we may now encounter different behavior when using different string types. For example, previously `assert_that(equal_to(['a', u'b', b'c'], ['a', 'b', 'c]))` worked, but now it may not because this sorting order now depends on the exact type (i.e. the sorting may produce `[u'b', 'a', b'c'`) even for orderable types. Should we consider this a regression? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 154010) Time Spent: 1h 40m (was: 1.5h) > Several tests fail on Python 3 with TypeError: unorderable types: str() < > int() > ------------------------------------------------------------------------------- > > Key: BEAM-5621 > URL: https://issues.apache.org/jira/browse/BEAM-5621 > Project: Beam > Issue Type: Sub-task > Components: sdk-py-core > Reporter: Valentyn Tymofieiev > Assignee: Juta Staes > Priority: Major > Fix For: Not applicable > > Time Spent: 1h 40m > Remaining Estimate: 0h > > ====================================================================== > ERROR: test_remove_duplicates > (apache_beam.transforms.ptransform_test.PTransformTest) > ---------------------------------------------------------------------- > Traceback (most recent call last): > File > "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/runners/common.py", > line 677, in process > self.do_fn_invoker.invoke_process(windowed_value) > File > "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/runners/common.py", > line 414, in invoke_process > windowed_value, self.process_method(windowed_value.value)) > File > "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/transforms/core.py", > line 1068, in <lambda> > wrapper = lambda x: [fn(x)] > File > "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/testing/util.py", > line 115, in _equal > sorted_expected = sorted(expected) > TypeError: unorderable types: str() < int() -- This message was sent by Atlassian JIRA (v7.6.3#76005)