[
https://issues.apache.org/jira/browse/BEAM-5621?focusedWorklogId=154042&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-154042
]
ASF GitHub Bot logged work on BEAM-5621:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Oct/18 21:47
Start Date: 12/Oct/18 21:47
Worklog Time Spent: 10m
Work Description: tvalentyn edited a comment on issue #6602: [BEAM-5621]
Fix unorderable types in python 3
URL: https://github.com/apache/beam/pull/6602#issuecomment-429468709
Another somewhat related observation:
Following snippets fails on Python 2, after this PR (in Direct Runner), but
will pass in Python 3 where there is no distinction between `int` and `long`.
```
p = TestPipeline(options=PipelineOptions(pipeline_args))
input_data = p | beam.Create([1, -2]) # This becomes a [1, -2L]!
(Unrelated to this PR).
expected_result = [-2, 1]
assert_that(input_data, equal_to(expected_result))
```
```
apache_beam.testing.util.BeamAssertException: Failed assert: [-2, 1] == [1,
-2L] [while running 'assert_that/Match']
```
Do we know why negatives are represented as longs?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 154042)
Time Spent: 2h 20m (was: 2h 10m)
> Several tests fail on Python 3 with TypeError: unorderable types: str() <
> int()
> -------------------------------------------------------------------------------
>
> Key: BEAM-5621
> URL: https://issues.apache.org/jira/browse/BEAM-5621
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Valentyn Tymofieiev
> Assignee: Juta Staes
> Priority: Major
> Fix For: Not applicable
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> ======================================================================
> ERROR: test_remove_duplicates
> (apache_beam.transforms.ptransform_test.PTransformTest)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File
> "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/runners/common.py",
> line 677, in process
> self.do_fn_invoker.invoke_process(windowed_value)
> File
> "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/runners/common.py",
> line 414, in invoke_process
> windowed_value, self.process_method(windowed_value.value))
> File
> "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/transforms/core.py",
> line 1068, in <lambda>
> wrapper = lambda x: [fn(x)]
> File
> "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/testing/util.py",
> line 115, in _equal
> sorted_expected = sorted(expected)
> TypeError: unorderable types: str() < int()
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
