JozoVilcek commented on issue #10943: [BEAM-9360] Fix equivalence check for FieldType URL: https://github.com/apache/beam/pull/10943#issuecomment-594795878 The problem was not in the protobuf extensions. It just did stumble upon bug in schema through regular use it. Test case makes sure that FieldTypes, part of schema, are compared correctly in terms of equivalence. Does not matter which schema provider actually did generate them. I believe test is sufficient. If you do have specific suggestions to add for improving quality and coverage, I am happy to work on them. Otherwise, imho it is ready for merge.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
