rohdesamuel commented on a change in pull request #11005: [BEAM-8335] Modify
the StreamingCache to subclass the CacheManager
URL: https://github.com/apache/beam/pull/11005#discussion_r389205758
##########
File path: sdks/python/apache_beam/runners/direct/transform_evaluator.py
##########
@@ -500,23 +523,21 @@ def __init__(
input_committed_bundle,
side_inputs)
self.test_stream = applied_ptransform.transform
+ self.event_index = 0
Review comment:
Removed this. Also, the is_done is needed because of the small cleanup.
There used to be a weird C++ iterator style on the TestStream object to get the
event. So there needs to be a small state variable from the process_elements
call to the finish_bundle call informing itself if there are any more elements
to process.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
