robertwb commented on a change in pull request #11005: [BEAM-8335] Modify the
StreamingCache to subclass the CacheManager
URL: https://github.com/apache/beam/pull/11005#discussion_r389136914
##########
File path: sdks/python/apache_beam/runners/direct/transform_evaluator.py
##########
@@ -500,23 +523,21 @@ def __init__(
input_committed_bundle,
side_inputs)
self.test_stream = applied_ptransform.transform
+ self.event_index = 0
Review comment:
Why did this have to move out of start_bundle? (Similarly, why do we need
is_done now and didn't before?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
