lukecwik commented on a change in pull request #9758: [BEAM-8374] Enable returning missing PublishResult fields in SnsIO.Write URL: https://github.com/apache/beam/pull/9758#discussion_r390477517
########## File path: sdks/java/io/amazon-web-services/src/main/java/org/apache/beam/sdk/io/aws/coders/AwsCoders.java ########## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.beam.sdk.io.aws.coders; + +import com.amazonaws.ResponseMetadata; +import com.amazonaws.http.HttpResponse; +import com.amazonaws.http.SdkHttpMetadata; +import java.io.IOException; +import java.io.InputStream; +import java.io.OutputStream; +import java.io.Serializable; +import java.util.List; +import java.util.Map; +import java.util.Optional; +import org.apache.beam.sdk.coders.Coder; +import org.apache.beam.sdk.coders.CoderException; +import org.apache.beam.sdk.coders.MapCoder; +import org.apache.beam.sdk.coders.NullableCoder; +import org.apache.beam.sdk.coders.StringUtf8Coder; +import org.apache.beam.sdk.coders.VarIntCoder; +import org.apache.beam.vendor.guava.v26_0_jre.com.google.common.collect.ImmutableList; +import org.apache.beam.vendor.guava.v26_0_jre.com.google.common.collect.ImmutableMap; + +/** {@link Coder}s for common AWS SDK objects. */ +public final class AwsCoders { + + private AwsCoders() {} + + /** + * Returns a new coder for ResponseMetadata. + * + * @return the ResponseMetadata coder + */ + public static Coder<ResponseMetadata> responseMetadata() { + return ResponseMetadataCoder.of(); + } + + /** + * Returns a new coder for SdkHttpMetadata that by default does not serialize the response + * headers. + * + * @return the SdkHttpMetadata coder + */ + public static Coder<SdkHttpMetadata> sdkHttpMetadata() { + return new SdkHttpMetadataCoder(false); + } + + /** + * Returns a new coder for SdkHttpMetadata that will serialize the response headers if indicated. + * + * @param includeHeaders <code>true</code> to serialize the SDK response headers, otherwise <code> + * false</code> + * @return the SdkHttpMetadata coder + */ + public static Coder<SdkHttpMetadata> sdkHttpMetadata(boolean includeHeaders) { + return new SdkHttpMetadataCoder(includeHeaders); + } + + private static class ResponseMetadataCoder extends Coder<ResponseMetadata> + implements Serializable { + + private static final Coder<Map<String, String>> METADATA_ENCODER = + NullableCoder.of(MapCoder.of(StringUtf8Coder.of(), StringUtf8Coder.of())); + private static final ResponseMetadataCoder INSTANCE = new ResponseMetadataCoder(); + + private ResponseMetadataCoder() {} + + public static ResponseMetadataCoder of() { + return INSTANCE; + } + + @Override + public void encode(ResponseMetadata value, OutputStream outStream) + throws CoderException, IOException { + METADATA_ENCODER.encode( + ImmutableMap.of(ResponseMetadata.AWS_REQUEST_ID, value.getRequestId()), outStream); + } + + @Override + public ResponseMetadata decode(InputStream inStream) throws CoderException, IOException { + return new ResponseMetadata(METADATA_ENCODER.decode(inStream)); + } + + @Override + public List<? extends Coder<?>> getCoderArguments() { + return ImmutableList.of(); + } + + @Override + public void verifyDeterministic() throws NonDeterministicException { + METADATA_ENCODER.verifyDeterministic(); + } + } + + private static class SdkHttpMetadataCoder extends Coder<SdkHttpMetadata> implements Serializable { Review comment: Please extend CustomCoder and remove the getCoderArguments method below. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
