lukecwik commented on a change in pull request #9758: [BEAM-8374] Enable
returning missing PublishResult fields in SnsIO.Write
URL: https://github.com/apache/beam/pull/9758#discussion_r390486072
##########
File path:
sdks/java/io/amazon-web-services/src/main/java/org/apache/beam/sdk/io/aws/sns/SnsIO.java
##########
@@ -257,12 +269,37 @@ public Write withResultOutputTag(TupleTag<PublishResult>
results) {
return builder().setResultOutputTag(results).build();
}
+ /**
+ * Encode the full {@code PublishResult} object, including
sdkResponseMetadata and
+ * sdkHttpMetadata but excluding the HTTP response headers.
+ */
+ public Write withFullPublishResultNoHeaders() {
+ return
builder().setCoder(PublishResultCoders.fullPublishResultNoHeaders()).build();
+ }
+
+ /**
+ * Encode the full {@code PublishResult} object, including
sdkResponseMetadata and
+ * sdkHttpMetadata with the HTTP response headers.
+ */
+ public Write withFullPublishResultIncludingHeaders() {
+ return
builder().setCoder(PublishResultCoders.fullPublishResultIncludingHeaders()).build();
+ }
+
+ /** Encode the {@code PublishResult} with the given coder. */
+ public Write withPublishResultCoder(Coder<PublishResult> coder) {
+ return builder().setCoder(coder).build();
+ }
+
@Override
public PCollectionTuple expand(PCollection<PublishRequest> input) {
checkArgument(getTopicName() != null, "withTopicName() is required");
- return input.apply(
- ParDo.of(new SnsWriterFn(this))
- .withOutputTags(getResultOutputTag(), TupleTagList.empty()));
+ PCollectionTuple result =
+ input.apply(
+ ParDo.of(new SnsWriterFn(this))
+ .withOutputTags(getResultOutputTag(), TupleTagList.empty()));
+ Optional.ofNullable(getCoder())
+ .ifPresent(coder ->
result.get(getResultOutputTag()).setCoder(coder));
Review comment:
nit: It is much easier for someone to understand the following logic:
```suggestion
if (getCoder() != null) {
result.get(getResultOutputTag()).setCoder(coder);
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
