Ardagan commented on a change in pull request #11076: Run precommit portability
on java 11
URL: https://github.com/apache/beam/pull/11076#discussion_r391112088
##########
File path: build.gradle
##########
@@ -335,3 +335,27 @@ if (project.hasProperty('javaLinkageArtifactIds')) {
}
}
}
+
+if (project.hasProperty('runWithJava11')) {
+ allprojects {
+ plugins.withId('java') {
+
+ java {
+ sourceCompatibility = JavaVersion.VERSION_1_8
+ targetCompatibility = JavaVersion.VERSION_1_8
+ }
+
+ tasks.withType(JavaCompile) {
+ options.with {
+ fork = true
+ forkOptions.javaHome = java8Home as File
+ }
+ }
+
+ test {
Review comment:
I'd also suggest to add test that validates runtime/compile time java
version. This will make reviews much easier.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
